[SPARK-57693][BUILD] Simplify kubernetes-client deps management by using BOM#56774
[SPARK-57693][BUILD] Simplify kubernetes-client deps management by using BOM#56774gillespeiffer-db wants to merge 1 commit into
kubernetes-client deps management by using BOM#56774Conversation
Import the `io.fabric8:kubernetes-client-bom` Bill of Materials in the root
`pom.xml` `<dependencyManagement>` section (at the existing
`${kubernetes-client.version}`) and drop the now-redundant
`<version>${kubernetes-client.version}</version>` pins from the five
`io.fabric8` dependency declarations in the Kubernetes resource-manager modules
(`kubernetes-client`, `volcano-client`, and `volcano-model`).
Mirror the BOM in `project/SparkBuild.scala`, the same way the existing
`jackson-bom` and `grpc-bom` imports are handled, because sbt-pom-reader does
not process import-scope BOMs.
This collapses five individually-pinned version references into a single BOM
import and keeps every Fabric8 artifact aligned to one coherent version set,
following the pattern already used for `jackson-bom`, `jjwt-bom`, and
`grpc-bom`. It is a no-op: the BOM manages `kubernetes-client`,
`volcano-client`, and `volcano-model` at the same version that was pinned
before, so the resolved versions are unchanged.
uros-b
left a comment
uros-b
left a comment
There was a problem hiding this comment.
Thank you @gillespeiffer-db - looks like a clean, mechanical BOM consolidation following the merged grpc/jackson-bom patterns. @dongjoon-hyun @panbingkun PTAL ^^
|
Hi folks, is anything else needed here? |
No, @gillespeiffer-db . The committers were too busy during Apache Spark 4.2.0 RC4. Now, RC4 failed and we have some time to revisit this kind of PRs. Thank you for your patience, @gillespeiffer-db . |
dongjoon-hyun
changed the title
kubernetes-client deps management by using BOM
|
Merged to master for Apache Spark 5.0.0. I added you to the Apache Spark contributor group and assigned SPARK-57693 to you, @gillespeiffer-db . |
|
To @gillespeiffer-db and @uros-b . I adjusted @gillespeiffer-db 's previous contribution's JIRA information together.
|
|
Thank you @dongjoon-hyun and @uros-b! |
3 participants
What changes were proposed in this pull request?
This PR uses
io.fabric8:kubernetes-client-bomto manageio.fabric8artifact versions, replacing the per-artifact<version>${kubernetes-client.version}</version>declarations acrossresource-managers/kubernetes/coreandresource-managers/kubernetes/integration-tests(kubernetes-client,volcano-client,volcano-model). The BOM is mirrored inproject/SparkBuild.scala(sbt-pom-reader does not process import-scope BOMs). Mirrors the existingjackson-bom(#52668),jjwt-bom(#56155), andgrpc-bom(#56741) imports.Why are the changes needed?
Simplify dependency management.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs. No-op on dependency resolution —
io.fabric8resolves identically (7.7.0, direct and transitive) before/after, verified withbuild/mvn help:effective-pomandbuild/mvn dependency:tree.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)